Now the lcore ID has been verified in framework API, so remove the verification in driver.
Signed-off-by: Huisong Li <[email protected]> --- drivers/power/amd_pstate/amd_pstate_cpufreq.c | 65 ------------------- 1 file changed, 65 deletions(-) diff --git a/drivers/power/amd_pstate/amd_pstate_cpufreq.c b/drivers/power/amd_pstate/amd_pstate_cpufreq.c index 68d4d3472c..8ca27d689d 100644 --- a/drivers/power/amd_pstate/amd_pstate_cpufreq.c +++ b/drivers/power/amd_pstate/amd_pstate_cpufreq.c @@ -360,11 +360,6 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) return -1; } - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; exp_state = POWER_IDLE; /* The power in use state works as a guard variable between @@ -442,11 +437,6 @@ power_amd_pstate_cpufreq_exit(unsigned int lcore_id) struct amd_pstate_power_info *pi; uint32_t exp_state; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; exp_state = POWER_USED; /* The power in use state works as a guard variable between @@ -492,11 +482,6 @@ power_amd_pstate_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return 0; - } - if (freqs == NULL) { POWER_LOG(ERR, "NULL buffer supplied"); return 0; @@ -515,22 +500,12 @@ power_amd_pstate_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t uint32_t power_amd_pstate_cpufreq_get_freq(unsigned int lcore_id) { - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return RTE_POWER_INVALID_FREQ_INDEX; - } - return lcore_power_info[lcore_id].curr_idx; } int power_amd_pstate_cpufreq_set_freq(unsigned int lcore_id, uint32_t index) { - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - return set_freq_internal(&(lcore_power_info[lcore_id]), index); } @@ -539,11 +514,6 @@ power_amd_pstate_cpufreq_freq_down(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->curr_idx + 1 == pi->nb_freqs) return 0; @@ -557,11 +527,6 @@ power_amd_pstate_cpufreq_freq_up(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->curr_idx == 0 || (pi->curr_idx == pi->nom_idx && pi->turbo_available && !pi->turbo_enable)) @@ -574,11 +539,6 @@ power_amd_pstate_cpufreq_freq_up(unsigned int lcore_id) int power_amd_pstate_cpufreq_freq_max(unsigned int lcore_id) { - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - /* Frequencies in the array are from high to low. */ if (lcore_power_info[lcore_id].turbo_available) { if (lcore_power_info[lcore_id].turbo_enable) @@ -599,11 +559,6 @@ power_amd_pstate_cpufreq_freq_min(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; /* Frequencies in the array are from high to low. */ @@ -615,11 +570,6 @@ power_amd_pstate_turbo_status(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; return pi->turbo_enable; @@ -630,11 +580,6 @@ power_amd_pstate_enable_turbo(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; if (pi->turbo_available) @@ -666,11 +611,6 @@ power_amd_pstate_disable_turbo(unsigned int lcore_id) { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - pi = &lcore_power_info[lcore_id]; pi->turbo_enable = 0; @@ -694,11 +634,6 @@ power_amd_pstate_get_capabilities(unsigned int lcore_id, { struct amd_pstate_power_info *pi; - if (!rte_lcore_is_enabled(lcore_id)) { - POWER_LOG(ERR, "lcore id %u is not enabled", lcore_id); - return -1; - } - if (caps == NULL) { POWER_LOG(ERR, "Invalid argument"); return -1; -- 2.33.0
