[PATCH 3/7] net/nfb: support real link-up/down config

[spinler]

From: Martin Spinler <spin...@cesnet.cz>

Use the standard PMA reset bit in the MDIO registers
to configure of the link-up/link-down state.

Signed-off-by: Martin Spinler <spin...@cesnet.cz>
---
 drivers/net/nfb/nfb_ethdev.c | 36 +++++++++++++++++++++++++++++-------
 1 file changed, 29 insertions(+), 7 deletions(-)

diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 437aed9ae7..950754f4cf 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -410,6 +410,29 @@ nfb_eth_link_update(struct rte_eth_dev *dev,
        return 0;
 }
 
+static int
+nfb_eth_dev_set_link(struct pmd_internals *intl, bool val)
+{
+       int reg;
+       struct mdio_if_info *if_info;
+
+       if (!intl->max_eth)
+               return 0;
+
+       if_info = &intl->eth_node[0].if_info;
+
+       reg = nfb_mdio_if_read_pma(if_info, NFB_MDIO_PMA_CTRL);
+       if (reg < 0)
+               return reg;
+
+       /* Update PMA Reset flag if necessary (Reset flag set means link down) 
*/
+       if ((reg & NFB_MDIO_PMA_CTRL_RESET) != (val ? 0 : 
NFB_MDIO_PMA_CTRL_RESET)) {
+               reg ^= NFB_MDIO_PMA_CTRL_RESET;
+               return nfb_mdio_if_write_pma(if_info, NFB_MDIO_PMA_CTRL, reg);
+       }
+       return 0;
+}
+
 /**
  * DPDK callback to bring the link UP.
  *
@@ -422,17 +445,16 @@ nfb_eth_link_update(struct rte_eth_dev *dev,
 static int
 nfb_eth_dev_set_link_up(struct rte_eth_dev *dev)
 {
-       struct pmd_internals *internals = (struct pmd_internals *)
-               dev->process_private;
-
+       struct pmd_internals *internals = dev->process_private;
        uint16_t i;
+
        for (i = 0; i < internals->max_rxmac; ++i)
                nc_rxmac_enable(internals->rxmac[i]);
 
        for (i = 0; i < internals->max_txmac; ++i)
                nc_txmac_enable(internals->txmac[i]);
 
-       return 0;
+       return nfb_eth_dev_set_link(internals, true);
 }
 
 /**
@@ -447,17 +469,17 @@ nfb_eth_dev_set_link_up(struct rte_eth_dev *dev)
 static int
 nfb_eth_dev_set_link_down(struct rte_eth_dev *dev)
 {
-       struct pmd_internals *internals = (struct pmd_internals *)
-               dev->process_private;
+       struct pmd_internals *internals = dev->process_private;
 
        uint16_t i;
+
        for (i = 0; i < internals->max_rxmac; ++i)
                nc_rxmac_disable(internals->rxmac[i]);
 
        for (i = 0; i < internals->max_txmac; ++i)
                nc_txmac_disable(internals->txmac[i]);
 
-       return 0;
+       return nfb_eth_dev_set_link(internals, false);
 }
 
 static uint64_t
-- 
2.53.0