Hello, On Wed, 21 Jan 2026 at 10:46, Marat Khalili <[email protected]> wrote: > > > > Fix f-string syntax errors where double quotes were nested inside > > f-strings that also use double quotes as delimiters. > > --- > > dts/api/testpmd/__init__.py | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/dts/api/testpmd/__init__.py b/dts/api/testpmd/__init__.py > > index a20dedc25a..703cae487e 100644 > > --- a/dts/api/testpmd/__init__.py > > +++ b/dts/api/testpmd/__init__.py > > @@ -227,7 +227,7 @@ def start_tx_first(self, burst_num: int, verify: bool = > > True) -> None: > > InteractiveCommandExecutionError: If `verify` is :data:`True` > > and forwarding fails to > > start or ports fail to come up. > > """ > > - self.send_command(f"start tx_first {burst_num if burst_num is not > > None else ""}") > > + self.send_command(f"start tx_first {burst_num if burst_num is not > > None else ''}") > > if verify: > > # If forwarding was already started, sending "start" again > > should tell us > > start_cmd_output = self.send_command("start") > > @@ -898,11 +898,11 @@ def set_qinq_strip(self, port: int, enable: bool, > > verify: bool = True) -> None: > > vlan_settings = self.show_port_info(port_id=port).vlan_offload > > if enable ^ (vlan_settings is not None and > > VLANOffloadFlag.QINQ_STRIP in vlan_settings): > > self._logger.debug( > > - f"Failed to {"enable" if enable else "disable"}" > > + f"Failed to {'enable' if enable else 'disable'}" > > f"QinQ strip on port {port}: \n{qinq_cmd_output}" > > ) > > raise InteractiveCommandExecutionError( > > - f"Failed to {"enable" if enable else "disable"} QinQ > > strip on port {port}" > > + f"Failed to {'enable' if enable else 'disable'} QinQ > > strip on port {port}" > > ) > > > > def set_mac_address(self, port: int, mac_address: str, verify: bool = > > True) -> None: > > @@ -1535,7 +1535,7 @@ def set_port_mbuf_fast_free( > > InteractiveCommandExecutionError: If mbuf_fast_free could not > > be set successfully. > > """ > > mbuf_output = self.send_command( > > - f"port config {port_id} tx_offload mbuf_fast_free {"on" if on > > else "off"}" > > + f"port config {port_id} tx_offload mbuf_fast_free {'on' if on > > else 'off'}" > > ) > > > > if verify and "Error" in mbuf_output: > > -- > > 2.43.7 > > Acked-by: Marat Khalili <[email protected]> > > Thank you, this noise in the compile logs was a bit annoying. I have to ask > however, how did it pass? Are we ignoring some errors?
Yes, I ended with the same conclusion and sent a fix earlier. https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ -- David Marchand
