On Wed, 14 Jan 2026 19:27:44 -0800
Dimon Zhao <[email protected]> wrote:
> Address multiple issues reported by Coverity static analysis:
>
> Check return values of ioctl() calls for NBL_DEV_USER_GET_BAR_SIZE
> and NBL_DEV_USER_CLEAR_EVENTFD. The original code tested the return
> value without capturing it from the ioctl call.
>
> Move debug log statement after NULL pointer validation in
> nbl_dev_configure() to prevent dereference of adapter before the
> check.
>
> Cast u16 operands to u64 before multiplication when calculating
> buffer sizes and offsets to prevent potential integer overflow.
> The num_txq_entries, num_rxq_entries, txq_buf_size, and rxq_buf_size
> fields are all u16 types, and their product could overflow before
> assignment to size_t or u64 destination variables.
>
> Coverity issue: 490942
> Coverity issue: 490943
> Coverity issue: 490946
> Coverity issue: 490947
> Coverity issue: 490949
> Coverity issue: 490950
> Coverity issue: 490951
> Coverity issue: 490952
> Coverity issue: 490953
> Coverity issue: 490954
> Coverity issue: 490955
> Coverity issue: 490957
> Coverity issue: 490958
> Coverity issue: 490959
> Fixes: a1c5ffa13b2c ("net/nbl: add channel layer")
> Fixes: dc955cd24c8f ("net/nbl: add coexistence mode")
> Fixes: 93b38df5a2ec ("net/nbl: support basic configuration")
> Cc: [email protected]
>
> Signed-off-by: Dimon Zhao <[email protected]>
>
Queued to next-net
