On Thu, 2 Oct 2025 at 10:07, Bruce Richardson <bruce.richard...@intel.com> wrote: > On Thu, Oct 02, 2025 at 09:53:15AM +0200, David Marchand wrote: > > It's a pity meson refuses to define user helpers... so much copy/paste > > in this patch. > > > > Yes, though if we want to reduce it I can remove some that is currently > unnecessary. For example, windows support doesn't have any cross-compile > options and only supports a single target so the checks there probably > aren't necessary. I added them for consistency.
For many (all?) DPDK devs, copy/paste is the rule when it comes to meson stuff. Let's keep this consistent. > > The other thing we could do to help out here, is check to see if any more > libraries can be switched to using pkg-config. I noticed some libs have > fallbacks after a pkg-config call - we could remove the fallbacks and just > mandate use of pkg-config for those. It may be differently implemented across distributions, and their versions.. I suspect we will still need the fallbacks. > > > This checking is not necessary (or should not be necessary) for > > > dependencies got using pkg-config, since the .pc files for each build > > > type are stored in a different directory on the system. > > > > Would it affect the library lookup if we pass has_headers to find_library()? > > > > I don't think it would affect things, since the headers are common in many > cases, only the binary files differ (thinking especially of the 32-bit vs > 64-bit case here). Ok, nevermind, I'm fine with this patch. -- David Marchand
