Hi,
On Thu, Sep 11, 2025, 22:53 Stephen Hemminger <step...@networkplumber.org>
wrote:
> On Thu, 11 Sep 2025 03:25:01 -0700
> Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote:
>
> > When the secondary process testpmd application running any fwd_engine
> > and after that primary has exited will cause a crash.
> >
> > This patch forces secondary process forwarding lcores
> > in fwd_engine to stop before the primary process exits.
> >
> > Fixes: a550baf24af90f ("app/testpmd: support multi-process")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk>
>
> NAK
> As you said, you did not test it on Windows, yet you added #ifdef
> for Windows support. Since Windows doesn't support secondary
> processes (yet) how could you.
>
> Adding Windows here has to wait until it can be tested.
>
Can you please double check the code?
I have used the following macro everywhere which means the code is only
targeted to Linux.
#ifndef RTE_EXEC_ENV_WINDOWS
I will add a newer version to if you agree to add additional comments to
further clarify that the solution is only targeted for Linux.
Best regards,
Khadem
>
