On 9/5/2025 8:34 AM, Bruce Richardson wrote:
On Tue, Sep 02, 2025 at 06:27:00PM +0100, Anatoly Burakov wrote:
From: Shaiq Wani <shaiq.w...@intel.com>
Packets dropped in the receive direction are counted as
"rx_unknown_protocol" (GLSWID_RUPP),these packets need to be added to the
"ipackets" and the GLV_GORCH/GLV_GORCL counters need to be added to
rx_bytes.
I assume from the code below that for the latter change, we don't actually
need to add them, but instead can just get them already included by reading
a different stats source?
Correct, those statistics are not counted in the vsi stats but they are
counted in the pf stats.
Signed-off-by: Jeff Shaw <jeffrey.b.s...@intel.com>
Signed-off-by: Shaiq Wani <shaiq.w...@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
---
drivers/net/intel/ice/ice_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/ice_ethdev.c
b/drivers/net/intel/ice/ice_ethdev.c
index 513777e372..0ebe58f858 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -6383,12 +6383,13 @@ ice_stats_get(struct rte_eth_dev *dev, struct
rte_eth_stats *stats)
stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
pf->main_vsi->eth_stats.rx_multicast +
+ ns->eth.rx_unknown_protocol +
pf->main_vsi->eth_stats.rx_broadcast -
pf->main_vsi->eth_stats.rx_discards;
stats->opackets = ns->eth.tx_unicast +
ns->eth.tx_multicast +
ns->eth.tx_broadcast;
- stats->ibytes = pf->main_vsi->eth_stats.rx_bytes;
+ stats->ibytes = ns->eth.rx_bytes;
stats->obytes = ns->eth.tx_bytes;
stats->oerrors = ns->eth.tx_errors +
pf->main_vsi->eth_stats.tx_errors;
--
2.47.3
