On Thu, 4 Sept 2025 at 16:19, <luca.bocca...@gmail.com> wrote:
>
> From: Luca Boccassi <luca.bocca...@gmail.com>
>
> The comment and docs say this should be built on x86_64 and aarch64,
> but RTE_ARCH_64 is not aarch64, that's RTE_ARCH_ARM64, so fix it.
>
> Also the check makes the build skip unless RTE_ARCH_X86_64 is true,
> so switch it to an 'and' instead of an 'or', to build on both arm64
> and x86_64, and skip elsewhere.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Luca Boccassi <luca.bocca...@gmail.com>
Good catch.
It seems we have similar construct in other drivers (and some of them
look buggy, like net/hns3 X and Y or Z without parens).
Could we align all on a single way of checking this combination?
$ git grep -B4 'only supported on x86_64 and aarch64'
drivers/common/sfc_efx/meson.build-endif
drivers/common/sfc_efx/meson.build-
drivers/common/sfc_efx/meson.build-if (arch_subdir != 'x86' and
arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/common/sfc_efx/meson.build- build = false
drivers/common/sfc_efx/meson.build: reason = 'only supported on
x86_64 and aarch64'
--
drivers/dma/hisilicon/meson.build-endif
drivers/dma/hisilicon/meson.build-
drivers/dma/hisilicon/meson.build-if (arch_subdir != 'x86' and
arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/dma/hisilicon/meson.build- build = false
drivers/dma/hisilicon/meson.build: reason = 'only supported on
x86_64 and aarch64'
--
drivers/net/hns3/meson.build-endif
drivers/net/hns3/meson.build-
drivers/net/hns3/meson.build-if arch_subdir != 'x86' and arch_subdir
!= 'arm' or not dpdk_conf.get('RTE_ARCH_64')
drivers/net/hns3/meson.build- build = false
drivers/net/hns3/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/net/sfc/meson.build-endif
drivers/net/sfc/meson.build-
drivers/net/sfc/meson.build-if (arch_subdir != 'x86' and arch_subdir
!= 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
drivers/net/sfc/meson.build- build = false
drivers/net/sfc/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/net/zxdh/meson.build-endif
drivers/net/zxdh/meson.build-
drivers/net/zxdh/meson.build-if not dpdk_conf.has('RTE_ARCH_X86_64')
or not dpdk_conf.get('RTE_ARCH_64')
drivers/net/zxdh/meson.build- build = false
drivers/net/zxdh/meson.build: reason = 'only supported on x86_64 and aarch64'
--
drivers/vdpa/sfc/meson.build-if ((arch_subdir != 'x86' or not
dpdk_conf.get('RTE_ARCH_64')) and
drivers/vdpa/sfc/meson.build- (arch_subdir != 'arm' or not
drivers/vdpa/sfc/meson.build-
host_machine.cpu_family().startswith('aarch64')))
drivers/vdpa/sfc/meson.build- build = false
drivers/vdpa/sfc/meson.build: reason = 'only supported on x86_64 and aarch64'
--
David Marchand
