In secondary processes, accessing 'dev->data->dev_private' directly can
cause a segmentation fault if the primary process has exited or the
shared memory is unavailable.

This patch adds a check for dev/data/dev_private and uses
rte_mem_virt2phy to ensure the pointer is still valid.

Fixes: bdad90d12ec8 ('ethdev: change device info get callback to return int')
Cc: sta...@dpdk.org

Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk>
---
 lib/ethdev/rte_ethdev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index dd7c00bc94..03ef446a96 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -4079,6 +4079,15 @@ rte_eth_dev_info_get(uint16_t port_id, struct 
rte_eth_dev_info *dev_info)
 
        if (dev->dev_ops->dev_infos_get == NULL)
                return -ENOTSUP;
+       if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
+               (dev == NULL || dev->data == NULL ||
+               dev->data->dev_private == NULL ||
+               rte_mem_virt2phy(dev->data->dev_private) == RTE_BAD_PHYS_ADDR)) 
{
+                       RTE_ETHDEV_LOG_LINE(ERR,
+                       "Secondary: dev_private not accessible (primary 
exited?)");
+                       rte_errno = ENODEV;
+                       return -rte_errno;
+       }
        diag = dev->dev_ops->dev_infos_get(dev, dev_info);
        if (diag != 0) {
                /* Cleanup already filled in device information */
-- 
2.43.0

Reply via email to