On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson
<bruce.richard...@intel.com> wrote:
> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
> index d3caa3a3b4..a9ff87e863 100644
> --- a/drivers/net/virtio/meson.build
> +++ b/drivers/net/virtio/meson.build
> @@ -31,7 +31,7 @@ if arch_subdir == 'x86'
> sources_avx512 += files('virtio_rxtx_packed.c')
> if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
> cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
> - elif (toolchain == 'clang' and
> cc.version().version_compare('>=3.7.0'))
> + elif (toolchain == 'clang')
> cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
> endif
> endif
One other nit, not blocking.
There should be no need for special casing clang vs gcc, since clang
supports gcc syntax in general.
https://clang.llvm.org/docs/AttributeReference.html#pragma-unroll-pragma-nounroll
The code could check for RTE_TOOLCHAIN_GCC/CLANG directly, and we
don't need a separate define passed from cmdline.
(idem in lib/vhost)
--
David Marchand
