Re: [PATCH] net/ice: fix assumption about tag placement order

[David Marchand]

On Thu, Jul 17, 2025 at 10:33 AM Bruce Richardson
<bruce.richard...@intel.com> wrote:
>
> On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote:
> > On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson
> > <bruce.richard...@intel.com> wrote:
> > >
> > > The specific placement of outer/inner VLAN tags in E810 and related NICs
> > > is configurable. Therefore, remove the assumption that if the L2Tag2
> > > field is filled in, that the L2Tag1 must also be. Instead, check the
> > > existing mbuf VLAN flags, and move tags and set flags as appropriate.
> > > This fixes an issue where, with QinQ packets with different Tag ethtypes
> > > (0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only
> > > having had one tag stripped.
> > >
> > > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> >
> > The ice code seems copy/pasted from i40e.
> > So I guess i40e is affected as well.
> >
>
> I'll investigate more. These fixes I intend for 25.11 anyway, since I'd

iavf has a similar helper.

> rather not risk them late in the 25.07 release cycle.

Yes, too late for the current release.


-- 
David Marchand