-----邮件原件----- 发件人: Stephen Hemminger <step...@networkplumber.org> 发送时间: 2025年7月7日 11:33 收件人: wangfeifei (J) <wangfeife...@huawei.com> 抄送: Feifei Wang <wff_li...@vip.163.com>; dev@dpdk.org; chenyi (CY) <chenyi...@huawei.com> 主题: Re: 回复: [V5 00/18] add hinic3 pmd driver
On Mon, 7 Jul 2025 03:27:20 +0000 "wangfeifei (J)" <wangfeife...@huawei.com> wrote: > -----邮件原件----- > 发件人: Stephen Hemminger <step...@networkplumber.org> > 发送时间: 2025年7月2日 22:56 > 收件人: Feifei Wang <wff_li...@vip.163.com> > 抄送: dev@dpdk.org; chenyi (CY) <chenyi...@huawei.com> > 主题: Re: [V5 00/18] add hinic3 pmd driver > > On Wed, 2 Jul 2025 10:09:23 +0800 > Feifei Wang <wff_li...@vip.163.com> wrote: > > > From: Yi Chen <chenyi...@huawei.com> > > > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver > > support for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > > > v5: > > - solve hinic3.ini unknown feature issue > > > > V4: > > - solve patch application conflict issue > > > > V3: > > - Fix checkpatchs error issue > > > > v2: > > - modify CI compile errors > > > > V1: > > - modify community comments and compile issues > > - remove the compilation flags in the meson build > > - remove (void) cast > > - remove "BLURE HERE ***" in cover letter > > > > RFC: > > - add hinic3 pmd driver code, modify the driver code to adapt to Huawei SPx > > series network cards. > > > > Feifei Wang (2): > > net/hinic3: add dev ops > > net/hinic3: add Rx/Tx functions > > > > Xin Wang (7): > > net/hinic3: add basic header files > > net/hinic3: add support for cmdq mechanism > > net/hinic3: add NIC event module > > net/hinic3: add context and work queue support > > net/hinic3: add device initialization > > net/hinic3: add MML and EEPROM access feature > > net/hinic3: add RSS promiscuous ops > > > > Yi Chen (9): > > add some basic files to describe the hinic3 driver. > > net/hinic3: add hardware interfaces of BAR operation > > net/hinic3: add eq mechanism function code > > net/hinic3: add mgmt module function code > > net/hinic3: add module about hardware operation > > net/hinic3: add a NIC business configuration module > > net/hinic3: add a mailbox communication module > > net/hinic3: add FDIR flow control module > > drivers/net: add hinic3 PMD build and doc files > > > > .mailmap | 4 +- > > MAINTAINERS | 6 + > > doc/guides/nics/features/hinic3.ini | 61 + > > doc/guides/nics/hinic3.rst | 51 + > > doc/guides/nics/index.rst | 1 + > > doc/guides/rel_notes/release_25_07.rst | 4 + > > drivers/net/hinic3/base/hinic3_cmd.h | 231 ++ > > drivers/net/hinic3/base/hinic3_cmdq.c | 978 +++++ > > drivers/net/hinic3/base/hinic3_cmdq.h | 230 ++ > > drivers/net/hinic3/base/hinic3_compat.h | 266 ++ > > drivers/net/hinic3/base/hinic3_csr.h | 108 + > > drivers/net/hinic3/base/hinic3_eqs.c | 721 ++++ > > drivers/net/hinic3/base/hinic3_eqs.h | 98 + > > drivers/net/hinic3/base/hinic3_hw_cfg.c | 240 ++ > > drivers/net/hinic3/base/hinic3_hw_cfg.h | 121 + > > drivers/net/hinic3/base/hinic3_hw_comm.c | 452 +++ > > drivers/net/hinic3/base/hinic3_hw_comm.h | 366 ++ > > drivers/net/hinic3/base/hinic3_hwdev.c | 573 +++ > > drivers/net/hinic3/base/hinic3_hwdev.h | 177 + > > drivers/net/hinic3/base/hinic3_hwif.c | 779 ++++ > > drivers/net/hinic3/base/hinic3_hwif.h | 142 + > > drivers/net/hinic3/base/hinic3_mbox.c | 1399 +++++++ > > drivers/net/hinic3/base/hinic3_mbox.h | 199 + > > drivers/net/hinic3/base/hinic3_mgmt.c | 392 ++ > > drivers/net/hinic3/base/hinic3_mgmt.h | 121 + > > drivers/net/hinic3/base/hinic3_nic_cfg.c | 1828 +++++++++ > > drivers/net/hinic3/base/hinic3_nic_cfg.h | 1527 ++++++++ > > drivers/net/hinic3/base/hinic3_nic_event.c | 433 +++ > > drivers/net/hinic3/base/hinic3_nic_event.h | 39 + > > drivers/net/hinic3/base/hinic3_wq.c | 148 + > > drivers/net/hinic3/base/hinic3_wq.h | 109 + > > drivers/net/hinic3/base/meson.build | 50 + > > drivers/net/hinic3/hinic3_ethdev.c | 3866 ++++++++++++++++++++ > > drivers/net/hinic3/hinic3_ethdev.h | 167 + > > drivers/net/hinic3/hinic3_fdir.c | 1394 +++++++ > > drivers/net/hinic3/hinic3_fdir.h | 398 ++ > > drivers/net/hinic3/hinic3_flow.c | 1700 +++++++++ > > drivers/net/hinic3/hinic3_flow.h | 42 + > > drivers/net/hinic3/hinic3_nic_io.c | 828 +++++ > > drivers/net/hinic3/hinic3_nic_io.h | 169 + > > drivers/net/hinic3/hinic3_rx.c | 1099 ++++++ > > drivers/net/hinic3/hinic3_rx.h | 356 ++ > > drivers/net/hinic3/hinic3_tx.c | 1028 ++++++ > > drivers/net/hinic3/hinic3_tx.h | 315 ++ > > drivers/net/hinic3/meson.build | 33 + > > drivers/net/hinic3/mml/hinic3_dbg.c | 171 + > > drivers/net/hinic3/mml/hinic3_dbg.h | 160 + > > drivers/net/hinic3/mml/hinic3_mml_cmd.c | 375 ++ > > drivers/net/hinic3/mml/hinic3_mml_cmd.h | 131 + > > drivers/net/hinic3/mml/hinic3_mml_ioctl.c | 215 ++ > > drivers/net/hinic3/mml/hinic3_mml_lib.c | 136 + > > drivers/net/hinic3/mml/hinic3_mml_lib.h | 276 ++ > > drivers/net/hinic3/mml/hinic3_mml_main.c | 167 + > > drivers/net/hinic3/mml/hinic3_mml_queue.c | 745 ++++ > > drivers/net/hinic3/mml/hinic3_mml_queue.h | 256 ++ > > drivers/net/hinic3/mml/meson.build | 45 + > > drivers/net/meson.build | 1 + > > 57 files changed, 25926 insertions(+), 1 deletion(-) create mode > > 100644 doc/guides/nics/features/hinic3.ini > > create mode 100644 doc/guides/nics/hinic3.rst create mode 100644 > > drivers/net/hinic3/base/hinic3_cmd.h > > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.c > > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.h > > create mode 100644 drivers/net/hinic3/base/hinic3_compat.h > > create mode 100644 drivers/net/hinic3/base/hinic3_csr.h > > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.c > > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.h > > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.c > > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.h > > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.c > > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.h > > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.c > > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.h > > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.c > > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.h > > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.c > > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.h > > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.c > > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.h > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.c > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.h > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.c > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.h > > create mode 100644 drivers/net/hinic3/base/hinic3_wq.c > > create mode 100644 drivers/net/hinic3/base/hinic3_wq.h > > create mode 100644 drivers/net/hinic3/base/meson.build > > create mode 100644 drivers/net/hinic3/hinic3_ethdev.c > > create mode 100644 drivers/net/hinic3/hinic3_ethdev.h > > create mode 100644 drivers/net/hinic3/hinic3_fdir.c create mode > > 100644 drivers/net/hinic3/hinic3_fdir.h create mode 100644 > > drivers/net/hinic3/hinic3_flow.c create mode 100644 > > drivers/net/hinic3/hinic3_flow.h create mode 100644 > > drivers/net/hinic3/hinic3_nic_io.c > > create mode 100644 drivers/net/hinic3/hinic3_nic_io.h > > create mode 100644 drivers/net/hinic3/hinic3_rx.c create mode > > 100644 drivers/net/hinic3/hinic3_rx.h create mode 100644 > > drivers/net/hinic3/hinic3_tx.c create mode 100644 > > drivers/net/hinic3/hinic3_tx.h create mode 100644 > > drivers/net/hinic3/meson.build create mode 100644 > > drivers/net/hinic3/mml/hinic3_dbg.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_dbg.h > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.h > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_ioctl.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.h > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_main.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.c > > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.h > > create mode 100644 drivers/net/hinic3/mml/meson.build > > > > Given the release roadmap, any new drivers need to be for 25.11 release now. > Marked as deferred for review after this release. > > [Feifei] Thanks for the remind. Have 2 questions: > 1. if this is for all new drivers will be deferred, or due to hinic3 driver > is not prepared, so it is deferred? > 2. before 25.11 release, if hinic3 can fix all comments, it can be sure to be > merged? The 25.07 release has reached the bugfix only stage. Will finish review and put in next-net next week (13 July 2025) [Feifei] Ok, please add our hinic3 driver to dpdk 25.11 roadmap. During this time, If have comments, we will fix as soon as possible. Thanks.
