https://bugs.dpdk.org/show_bug.cgi?id=1740
Bug ID: 1740 Summary: net/bnxt: duplicate code in branches Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: step...@networkplumber.org Target Milestone: --- Building with compiler warning about duplicate branches finds: [834/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_flow.c.o ../drivers/net/bnxt/bnxt_flow.c: In function ‘bnxt_validate_and_parse_flow_type’: ../drivers/net/bnxt/bnxt_flow.c:263:80: warning: this condition has identical branches [-Wduplicated-branches] 263 | NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR : | ^ ../drivers/net/bnxt/bnxt_flow.c:383:79: warning: this condition has identical branches [-Wduplicated-branches] 383 | HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 : | ^ ../drivers/net/bnxt/bnxt_flow.c:448:75: warning: this condition has identical branches [-Wduplicated-branches] 448 | NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 : | ^ [835/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_stats.c.o [836/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_rxq.c.o [837/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_txq.c.o [838/3631] Compiling C object drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_bnx2x_stats.c.o [839/3631] Compiling C object drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_ecore_sp.c.o [840/3631] Compiling C object drivers/libtmp_rte_common_qat.a.p/crypto_qat_qat_asym.c.o [841/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_txr.c.o ../drivers/net/bnxt/bnxt_txr.c: In function ‘bnxt_start_xmit’: ../drivers/net/bnxt/bnxt_txr.c:410:74: warning: duplicated ‘if’ condition [-Wduplicated-cond] 410 | } else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:402:78: note: previously used here 402 | } else if ((tx_pkt->ol_flags & PKT_TX_OIP_IIP_TCP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:418:70: warning: duplicated ‘if’ condition [-Wduplicated-cond] 418 | } else if ((tx_pkt->ol_flags & PKT_TX_IIP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:414:74: note: previously used here 414 | } else if ((tx_pkt->ol_flags & PKT_TX_IIP_TCP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:430:70: warning: duplicated ‘if’ condition [-Wduplicated-cond] 430 | } else if ((tx_pkt->ol_flags & PKT_TX_OIP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:426:74: note: previously used here 426 | } else if ((tx_pkt->ol_flags & PKT_TX_OIP_TCP_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:450:73: warning: duplicated ‘if’ condition [-Wduplicated-cond] 450 | } else if ((tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_CKSUM) == ../drivers/net/bnxt/bnxt_txr.c:442:70: note: previously used here 442 | } else if ((tx_pkt->ol_flags & PKT_TX_TCP_UDP_CKSUM) == [842/3631] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_reps.c.o -- You are receiving this mail because: You are the assignee for the bug.