Hi Patrick and Nick,

I am unsure what happened with this commit. The commit subject doesn't match what's happening here. Mentions a rework of the config module, which is not. Description seems ok.

Another issue I see is that some changes don't make a lot logical sense as they stand here. The changes in test_run.yaml, don't really belong here, and could be considered breaking. I am assuming they were improperly re-ordered between commits. Similarly I don't see appropriate doc changes to reflect the change in the configuration examples path.

On 02/07/2025 06:21, Patrick Robb wrote:
--- a/dts/test_run.example.yaml
+++ b/dts/configurations/test_run.example.yaml
@@ -1,8 +1,3 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright 2022-2023 The DPDK contributors
-# Copyright 2023 Arm Limited
-
-# Define the test run environment

And removing this line above, would cause in sphinx to complain as the example rendering relies on this line.

  dpdk:
    lcores: "" # use all available logical cores (Skips first core)
    memory_channels: 4 # tells DPDK to use 4 memory channels
@@ -23,8 +18,14 @@ dpdk:
      # in a subdirectory of DPDK tree root directory. Otherwise, will be using 
the `build_options`
      # to build the DPDK from source. Either `precompiled_build_dir` or 
`build_options` can be
      # defined, but not both.

Reply via email to