Hi,

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Tuesday, July 1, 2025 7:35 PM
> To: Gagandeep Singh <g.si...@nxp.com>
> Cc: dev@dpdk.org; Hemant Agrawal <hemant.agra...@nxp.com>; Sachin
> Saxena <sachin.sax...@nxp.com>; Vanshika Shukla
> <vanshika.shu...@nxp.com>
> Subject: Re: [PATCH v7 3/6] bus/fslmc: add DPBP APIs for setting depletion
> thresholds
> 
> On Tue,  1 Jul 2025 09:59:14 +0530
> Gagandeep Singh <g.si...@nxp.com> wrote:
> 
> > @@ -62,6 +72,8 @@ rte_dpaa2_mbuf_from_buf_addr(struct
> rte_mempool *mp,
> > void *buf_addr);  __rte_internal  int rte_dpaa2_bpid_info_init(struct
> > rte_mempool *mp);
> >
> > +int rte_dpaa2_dpbp_set_notifications(struct rte_mempool *mp, struct
> > +dpaa2_dpbp_cfg *dpbp_cfg);
> > +
> 
> This patch series still needs work:
>   - new API is not exported
>   - new API is not marked external
>   - new API needs a test
> 
> Ideally, you would figure out how to get same functionality without adding
> any new exported API.

Ok, we can drop this patch for now. we will submit it for next release.

Reply via email to