On Thu, Jun 26, 2025 at 07:00:11AM -0700, Stephen Hemminger wrote:
> On Mon, 23 Jun 2025 17:12:43 +0100
> Bruce Richardson <bruce.richard...@intel.com> wrote:
> 
> > On Mon, Jun 23, 2025 at 06:01:00PM +0200, David Marchand wrote:
> > > On Tue, May 27, 2025 at 5:29 PM Bruce Richardson
> > > <bruce.richard...@intel.com> wrote:  
> > > >
> > > > As the number of cores/cpus on platforms has increased over the years,
> > > > the use of coremasks rather than core-lists for identifying DPDK cores
> > > > has become more and more unwieldy. At this point, let's deprecate the
> > > > coremask-based EAL parameters for future removal, and point users to the
> > > > core-list based versions instead.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > > > ---
> > > >  doc/guides/eventdevs/dlb2.rst                |  6 +++---
> > > >  doc/guides/faq/faq.rst                       |  8 +++-----
> > > >  doc/guides/linux_gsg/build_sample_apps.rst   |  7 +++----
> > > >  doc/guides/linux_gsg/eal_args.include.rst    |  8 ++------
> > > >  doc/guides/prog_guide/meson_ut.rst           |  2 +-
> > > >  doc/guides/prog_guide/multi_proc_support.rst |  2 +-
> > > >  doc/guides/prog_guide/service_cores.rst      |  8 ++++----
> > > >  doc/guides/rel_notes/deprecation.rst         | 10 ++++++++++
> > > >  doc/guides/sample_app_ug/ip_frag.rst         |  7 +------
> > > >  doc/guides/sample_app_ug/ip_reassembly.rst   |  7 +------
> > > >  doc/guides/sample_app_ug/multi_process.rst   | 14 +++++---------
> > > >  doc/guides/sample_app_ug/qos_scheduler.rst   |  2 +-
> > > >  doc/guides/sample_app_ug/test_pipeline.rst   |  2 +-
> > > >  doc/guides/tools/testbbdev.rst               |  2 +-
> > > >  lib/eal/common/eal_common_options.c          |  6 ++++++
> > > >  15 files changed, 43 insertions(+), 48 deletions(-)  
> > > 
> > > This patch will need some rebase.
> > > 
> > > I see you fixed a few docs, but there are quite some misses in
> > > copy/pasted blocks:
> > >   
> > I'll take a look and respin this.
> > 
> > I'm think of separating it into two patches: first patch with the doc
> > updates to remove use of -c flag. This should happen independent of the
> > deprecation, I think, and second patch just the deprecation notice. Does
> > that sound reasonable?
> > 
> > /Bruce
> 
> Should also drop use of -n in all the doc examples.
> I had a patch for that probably buried somewhere.

Yep, agreed. I actually thought of doing so when doing patch [1], but
decided against mixing additional changes in with coremask changes.

/Bruce

[1] 
https://patches.dpdk.org/project/dpdk/patch/20250624133409.550372-3-bruce.richard...@intel.com/

Reply via email to