On Wed, Jun 25, 2025 at 06:27:51PM +0000, Jasper Tran O'Leary wrote:
> This commit adds small changes so that the gve driver can build when
> FreeBSD is the host operating system.
>
> Signed-off-by: Jasper Tran O'Leary <jtranole...@google.com>
> ---
> .mailmap | 1 +
> drivers/net/gve/base/gve_osdep.h | 2 +-
> drivers/net/gve/gve_ethdev.c | 2 +-
> drivers/net/gve/meson.build | 4 ++--
> 4 files changed, 5 insertions(+), 4 deletions(-)
>
Two very minor comments inline below.
/Bruce
> diff --git a/.mailmap b/.mailmap
> index 8483d96ec5..4ce891b223 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -650,6 +650,7 @@ Jaroslaw Gawin <jaroslawx.ga...@intel.com>
> Jaroslaw Ilgiewicz <jaroslaw.ilgiew...@intel.com>
> Jason He <jason...@broadcom.com>
> Jason Wang <jasow...@redhat.com>
> +Jasper Tran O'Leary <jtranole...@google.com>
> Jasvinder Singh <jasvinder.si...@intel.com>
> Jay Ding <jay.d...@broadcom.com>
> Jay Jayatheerthan <jay.jayatheert...@intel.com>
> diff --git a/drivers/net/gve/base/gve_osdep.h
> b/drivers/net/gve/base/gve_osdep.h
> index 5eb33930cd..365d44fdba 100644
> --- a/drivers/net/gve/base/gve_osdep.h
> +++ b/drivers/net/gve/base/gve_osdep.h
> @@ -25,7 +25,7 @@
>
> #include "../gve_logs.h"
>
> -#ifdef RTE_EXEC_ENV_LINUX
> +#if defined(RTE_EXEC_ENV_LINUX) || defined(RTE_EXEC_ENV_FREEBSD)
> #include <sys/utsname.h>
> #endif
>
Is this ifdef necessary if you only build on linux and freebsd (as per
meson.build below)?
> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
> index e471a34e61..bdb7f1d075 100644
> --- a/drivers/net/gve/gve_ethdev.c
> +++ b/drivers/net/gve/gve_ethdev.c
> @@ -1366,5 +1366,5 @@ static struct rte_pci_driver rte_gve_pmd = {
>
> RTE_PMD_REGISTER_PCI(net_gve, rte_gve_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(net_gve, pci_id_gve_map);
> -RTE_PMD_REGISTER_KMOD_DEP(net_gve, "* igb_uio | vfio-pci");
> +RTE_PMD_REGISTER_KMOD_DEP(net_gve, "* igb_uio | vfio-pci | nic_uio");
> RTE_LOG_REGISTER_SUFFIX(gve_logtype_driver, driver, NOTICE);
> diff --git a/drivers/net/gve/meson.build b/drivers/net/gve/meson.build
> index ed5ef0a1fc..14a17db4bf 100644
> --- a/drivers/net/gve/meson.build
> +++ b/drivers/net/gve/meson.build
> @@ -1,9 +1,9 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(C) 2022 Intel Corporation
>
> -if not is_linux
> +if not is_linux and not is_freebsd
> build = false
> - reason = 'only supported on Linux'
> + reason = 'only supported on Linux and FreeBSD'
> subdir_done()
> endif
>
Minor nit: generally DPDK drivers tend to report just "not supported on
Windows" rather than support for BSD and Linux.
> --
> 2.49.0
>
