On Mon, Jun 16, 2025 at 5:38 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Mon, Jun 16, 2025 at 08:31:11AM -0700, Andre Muezerie wrote: > > There is a minimum meson version specified in the DPDK meson project > > section, which has been documented. This string is parsed by > > buildtools\get-min-meson-version.py and this information is used by > > lab automation to install the corresponding meson package on the > > build machine. > > > > Turns out that the meson version specified on the DPDK project > > (0.57.x) is buggy on Windows: it has issues related to path > > manipulation, and these issues are causing failures. Therefore, > > a newer meson is required on Windows. > > > > To avoid bringing the minimum requirements up for all operating > > systems before a more appropriate release, this patch implements > > a mechanism allowing a different version to be specified for Windows. > > > > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Applied, thanks. Two (non blocking) comments on this patch: - could you send a followup patch for using this with the MSVC target in GHA (see .github/workflows/build.yml) ? - there is nothing really checking whether the minimum version is correct on Windows. Would it make sense to have a "runtime" check in meson out of the project() declaration? Something like (untested, probably broken): diff --git a/meson.build b/meson.build index 2423884df7..22128b6942 100644 --- a/meson.build +++ b/meson.build @@ -11,9 +11,13 @@ project('DPDK', 'c', 'warning_level=2', ], meson_version: '>= 0.57.2' - # meson_version_windows: '>= 1.5.2' ) +meson_version_windows='1.5.2' +if is_windows and meson.version() < meson_version_windows + error('Minimum meson version on Windows is ' + meson_version_windows) +endif + fs = import('fs') # check for developer mode -- David Marchand