03/06/2025 10:29, Bruce Richardson:
> On Fri, May 30, 2025 at 09:18:44AM +0100, Rui Ferreira wrote:
> > Unregister callback on cleanup to avoid use after free from the
> > interrupt thread (eal_intr_thread_main).
> >
> > To be more defensive, set ptr to NULL if we can unregister.
> >
> > rte_intr_callback_unregister_sync may (optionally) use traces
> > so the alarm cleanup must happen before eal_trace_fini to avoid
> > accessing freed memory.
> >
> > Bugzilla ID: 1683
>
> Source of bug is probably:
>
> Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle")
>
> >
> > Signed-off-by: Rui Ferreira <rui.ferrei...@h-partners.com>
>
> Patch looks ok to me.
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
I think we should keep trace saving just before trace closing.
Applied with this change, thanks.
