> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Thursday, September 12, 2024 11:20 AM
> To: Tyler Retzlaff <[email protected]>; Stephen Hemminger
> <[email protected]>; Brandes, Shai <[email protected]>
> Cc: [email protected]; Schmeilin, Evgeny <[email protected]>; Beider, Ron
> <[email protected]>; Bernstein, Amit <[email protected]>;
> Atrash, Wajeeh <[email protected]>; Chauskin, Igor
> <[email protected]>; Michal Krawczyk <[email protected]>; Artur Rojek
> <[email protected]>
> Subject: RE: [EXTERNAL] [PATCH] net/ena: revert redefining memcpy
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On 9/12/2024 6:12 AM, Tyler Retzlaff wrote:
> > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote:
> >> Redefining memcpy as rte_memcpy has no performance gain on current
> >> compilers, and introduced bugs like this one where
> >> rte_memcpy() will be detected as referencing past the destination.
> >>
> >> Bugzilla ID: 1510
> >> Fixes: 142778b3702a ("net/ena: switch memcpy to optimized version")
> >>
> >> Signed-off-by: Stephen Hemminger <[email protected]>
> >> ---
> >
> > Acked-by: Tyler Retzlaff <[email protected]>
> >
>
> Hi Shai,
>
> Did you have any chance to check/test this patch?
[Brandes, Shai] We are currently conducting tests and will provide an update
shortly. In the meantime, could you advise whether it is recommended to
entirely avoid using rte_memcpy in our driver, considering we have direct calls
to it?
