I think there was just one typo, otherwise: Reviewed-by: Jeremy Spewock <[email protected]>
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro <[email protected]> wrote: > > This commit introduces a new "params" module, which adds a new way > to manage command line parameters. The provided Params dataclass > is able to read the fields of its child class and produce a string > representation to supply to the command line. Any data structure > that is intended to represent command line parameters can inherit it. > > The main purpose is to make it easier to represent data structures that > map to parameters. Aiding quicker development, while minimising code > bloat. > > Signed-off-by: Luca Vizzarro <[email protected]> > Reviewed-by: Paul Szczepanek <[email protected]> > --- <snip> > +def comma_separated(values: Iterable[Any]) -> str: > + """Converts an iterable in a comma-separated string.""" I think this was meant to be "...an iterable into a comma-separated..." > + return ",".join([str(value).strip() for value in values if value is not > None]) > + > + <snip> > 2.34.1 >
