[AMD Official Use Only - General] > -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Thursday, March 21, 2024 4:48 PM > To: Tummala, Sivaprasad <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > Yigit, > Ferruh <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Morten Brørup <[email protected]> > Subject: Re: [PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > 21/03/2024 12:05, Tummala, Sivaprasad: > > From: Thomas Monjalon <[email protected]> > > > 19/03/2024 08:24, Morten Brørup: > > > > > From: Sivaprasad Tummala [mailto:[email protected]] > > > > > Sent: Monday, 18 March 2024 18.32 > > > > > > > > > > Currently the config option allows lcore IDs up to 255, > > > > > irrespective of RTE_MAX_LCORES and needs to be fixed. > > > > > > > > > > The patch allows config options based on DPDK config. > > > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > > Cc: [email protected] > > > > > > > > > > Signed-off-by: Sivaprasad Tummala <[email protected]> > > > > > Acked-by: Konstantin Ananyev <[email protected]> > > > > > --- > > > > > > > > I suggest you update the description of the individual patches > > > > too, like you did > > > for patch 0/6. > > > > > > > > E.g. this patch not only fixes the lcore_id, but also the queue_id type > > > > size. > > > > > > > > > > > > For the series, > > > > Acked-by: Morten Brørup <[email protected]> > > > > > > I would recommend a separate patch for queue id as it is a separate issue. > > > However, there is no need to split per directory. > > > You can have patches changing all examples at once. > > > > > There's a functional dependency and queue id change is required to > > support higher lcore IDs and hence it makes sense to add in the same patch. > > I had split the examples to help the maintainers review the patches > > individually. > > Please feel free to squash the git commits while merging. > > Then if there is a dependency, please make queue id the first patch. OK! Will split the changes into separate patches in next version.
>
