Yes, you are correct, it should be the commit 2a7d0b872f79 that introduced the issue. Thank you for the correction.
[email protected] ------------------ ???????? ------------------ ??????: "David Marchand"<[email protected]>; ????????: 2024??2??1??(??????) ????9:14 ??????: " ShaoWei Sun"<[email protected]>; "ciara.power"<[email protected]>; ????: "dev"<[email protected]>; "Bruce Richardson"<[email protected]>; "Chengwen Feng"<[email protected]>; ????: Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail [email protected]> wrote: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will result in the machine running for a long time, and if there are > 10 failures, the telemetry will be unavailable > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > > Signed-off-by: Shaowei Sun <[email protected]> > Acked-by: Bruce Richardson <[email protected]> > Acked-by: Ciara Power <[email protected]> > Acked-by: Chengwen Feng <[email protected]> Thanks for the fix. As far as I can see, the limiting of the number of connections (which here results in a DoS on the telemetry socket) was added in commit 2a7d0b872f79 ("telemetry: add upper limit on connections"). If you confirm this is indeed this commit that introduced the issue, I will fix the Fixes: tag myself when applying. -- David Marchand
