HWS guys claimed this check was needed to make sure matcher works well on ESP. Are we sure we can remove this ?
> -----Original Message----- > From: Raslan Darawsheh <[email protected]> > Sent: Wednesday, January 17, 2024 7:12 PM > To: Michael Baum <[email protected]>; [email protected] > Cc: Matan Azrad <[email protected]>; Dariusz Sosnowski > <[email protected]>; Slava Ovsiienko <[email protected]>; Ori > Kam <[email protected]>; Suanming Mou <[email protected]>; Hamdan > Igbaria <[email protected]>; [email protected] > Subject: RE: [PATCH] net/mlx5/hws: fix ESP matching validation > > Hi, > > -----Original Message----- > > From: Michael Baum <[email protected]> > > Sent: Monday, January 15, 2024 2:10 PM > > To: [email protected] > > Cc: Matan Azrad <[email protected]>; Dariusz Sosnowski > > <[email protected]>; Raslan Darawsheh <[email protected]>; Slava > > Ovsiienko <[email protected]>; Ori Kam <[email protected]>; > > Suanming Mou <[email protected]>; Hamdan Igbaria > > <[email protected]>; [email protected] > > Subject: [PATCH] net/mlx5/hws: fix ESP matching validation > > > > The "mlx5dr_definer_conv_item_esp()" function validates first whether > > "ipsec_offload" PRM flag is on, if the flag is off the function > > returns error. > > > > The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt > > is supported, IPsec matching may be supported even when this flag is off. > > > > This patch removes this validation. > > > > Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item") > > Cc: [email protected] > > Cc: [email protected] > > > > Signed-off-by: Michael Baum <[email protected]> > > Acked-by: Hamdan Igbaria <[email protected]> > > Acked-by: Matan Azrad <[email protected]> > Patch applied to next-net-mlx, > > Kindest regards > Raslan Darawsheh
