Hi Bruce,

Thanks for the review and feedback. Please find my reply in-line.

Thanks,
Amit Shukla

> -----Original Message-----
> From: Bruce Richardson <[email protected]>
> Sent: Monday, December 11, 2023 3:54 PM
> To: Amit Prakash Shukla <[email protected]>
> Cc: Chengwen Feng <[email protected]>; Kevin Laatz
> <[email protected]>; [email protected]; Jerin Jacob Kollanukkaran
> <[email protected]>; Vamsi Krishna Attunuru <[email protected]>;
> Nithin Kumar Dabilpuram <[email protected]>; Anoob Joseph
> <[email protected]>; [email protected]
> Subject: [EXT] Re: [PATCH] lib/dmadev: get DMA device using device ID
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, Dec 08, 2023 at 01:25:25PM +0530, Amit Prakash Shukla wrote:
> > DMA library has a function to get DMA device based on device name but
> > there is no function to get DMA device using device id.
> >
> > Added a function that lookup for the dma device using device id and
> > returns the pointer to the same.
> >
> > Signed-off-by: Amit Prakash Shukla <[email protected]>
> > ---
> >  lib/dmadev/rte_dmadev.c     |  9 +++++++++
> >  lib/dmadev/rte_dmadev_pmd.h | 14 ++++++++++++++
> >  lib/dmadev/version.map      |  1 +
> >  3 files changed, 24 insertions(+)
> >
> What is the use-case for these functions? With the dmadev library
> abstraction, other libs and apps should never need a pointer to an dmadev
> struct.
[Amit]: The dmadev struct pointer is needed at driver layer to verify certain 
underlying device parameters which cannot be done as part of dma lib. This api 
is been used in the patch: 
https://patches.dpdk.org/project/dpdk/patch/[email protected]/

Reply via email to