For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event be longer than 1 second.
Cc: [email protected] Reported-by: Timothy Miskell Suggested-by: Timothy Miskell Signed-off-by: Timothy Miskell Reviewed-by: Larry Wang Tested-by: Jonathan Tsai --- .mailmap | 2 ++ drivers/net/ice/ice_ethdev.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 3f5bab26a8..93c09a23ee 100644 --- a/.mailmap +++ b/.mailmap @@ -674,6 +674,7 @@ John Romein <[email protected]> John W. Linville <[email protected]> Jonas Pfefferle <[email protected]> <[email protected]> Jonathan Erb <[email protected]> <[email protected]> +Jonathan Tsai <[email protected]> Jon DeVree <[email protected]> Jon Loeliger <[email protected]> Joongi Kim <[email protected]> @@ -1414,6 +1415,7 @@ Tianli Lai <[email protected]> Tianyu Li <[email protected]> Timmons C. Player <[email protected]> Timothy McDaniel <[email protected]> +Timothy Miskell <[email protected]> Timothy Redaelli <[email protected]> Tim Shearer <[email protected]> Ting Xu <[email protected]> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 305077e74e..6ef06b9926 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, static int ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { -#define CHECK_INTERVAL 100 /* 100ms */ -#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ +#define CHECK_INTERVAL 50 /* 50ms */ +#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */ struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_link_status link_status; struct rte_eth_link link, old; -- 2.25.1
