Hello, On Tue, Jul 11, 2023 at 12:00 AM Bili Dong <qobili...@gmail.com> wrote: > > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its > use case in P4. We implement it in this patch so it could be easily > registered in the pipeline later. > > Signed-off-by: Bili Dong <qobili...@gmail.com> > .mailmap | 1 + > app/test/test_hash_functions.c | 47 +++++++++++--- > lib/hash/rte_hash_xor.h | 113 +++++++++++++++++++++++++++++++++ > 3 files changed, 151 insertions(+), 10 deletions(-) > create mode 100644 lib/hash/rte_hash_xor.h >
I was about to merge this patch but there are some issues that should have been caught by the library maintainer... It seems the intention is to have a public API (meaning external DPDK apps) consumption. Then the header must be exported via 'headers' in lib/hash/meson.build. Besides, such API addition must be announced in the release notes. And this API should be documented either in some doc/guides/ or at least with doxygen (meaning that rte_hash_xor.h must be referenced in doc/api/doxy-api-index.md). Thanks. -- David Marchand
