> From: Tyler Retzlaff [mailto:[email protected]] > Sent: Wednesday, 16 August 2023 21.19 > > Provide API for atomic operations in the rte namespace that may > optionally be configured to use C11 atomics with meson > option enable_stdatomics=true > > Signed-off-by: Tyler Retzlaff <[email protected]> > Reviewed-by: Morten Brørup <[email protected]> > ---
"#define RTE_ATOMIC(type) [...]" is missing in lib/eal/include/rte_stdatomic.h, both with and without RTE_ENABLE_STDATOMIC. I suggest you keep it together with "#define __rte_atomic [...]". Please also add descriptions as comments to both (type-qualifier and -specifier) in both locations. Your descriptions from the mailing list discussion are fine.
