Thanks a lot, this problem that I have never been thought about it. Regards Wenbo. -----Original Message----- From: Stephen Hemminger <[email protected]> Sent: 2023年8月3日 0:08 To: Wenbo Cao <[email protected]> Cc: Anatoly Burakov <[email protected]>; [email protected]; [email protected]; [email protected] Subject: Re: [PATCH v2 3/8] net/rnp: add device init and uninit
On Wed, 2 Aug 2023 08:11:01 +0000 Wenbo Cao <[email protected]> wrote: > +struct rnp_hw { > + void *back; > + char *iobar0; > + uint32_t iobar0_len; > + char *iobar4; > + uint32_t iobar4_len; If possible, don't use untyped pointer for link list (back). The iobar's should probably be void * or better yet map to data structure. Casts are often a source of bugs in C code.
