________________________________
Konstantin Ananyev
Mobile: +353-873459988
Email: [email protected]
From:zhoumin <[email protected]>
To:Thomas Monjalon <[email protected]>;Ruifeng Wang
<[email protected]>;Zhang, Qi Z <[email protected]>
Cc:dev <[email protected]>;mb <[email protected]>;konstantin.v.ananyev
<[email protected]>;Yang, Qiming <[email protected]>;Wu,
Wenjun1 <[email protected]>;drc <[email protected]>;roretzla
<[email protected]>;stable <[email protected]>;maobibo
<[email protected]>;nd <[email protected]>;David Marchand
<[email protected]>;honnappa.nagarahalli
<[email protected]>;Tyler Retzlaff
<[email protected]>;Konstantin Ananyev <[email protected]>
Date:2023-06-13 04:43:12
Subject:Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx
functions
Hi Thomas,
On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote:
> 12/06/2023 13:58, zhoumin:
>> On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote:
>>> 15/05/2023 04:10, Zhang, Qi Z:
>>>> From: Ruifeng Wang <[email protected]<mailto:[email protected]>>
>>>>> From: Min Zhou <[email protected]<mailto:[email protected]>>
>>>>>> ---
>>>>>> v3:
>>>>>> - Use rte_smp_rmb() as the proper memory barrier instead of rte_rmb()
>>>>>> ---
>>>>>> v2:
>>>>>> - Make the calling of rte_rmb() for all platforms
>>>>>> ---
>>> [...]
>>>>> Reviewed-by: Ruifeng Wang
>>>>> <[email protected]<mailto:[email protected]>>
>>>> Applied to dpdk-next-net-intel.
>>>>
>>>> Thanks
>>>> Qi
>>>>
>>> Why ignoring checkpatch?
>>> It is saying:
>>> "
>>> Warning in drivers/net/ixgbe/ixgbe_rxtx.c:
>>> Using rte_smp_[r/w]mb
>>> "
>>
>> I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code?
> No we should avoid.
> It has been decided to slowly replace such barriers.
> By the way, I think it is not enough documented.
> You can find an explanation in doc/guides/rel_notes/deprecation.rst
Thank your for providing the reference documents. I have read this file.
The explanation is clear and I get it.
> I think we should also add some notes to
> lib/eal/include/generic/rte_atomic.h
Yes, I do think so. The notes added at the definitions of
rte_smp_[r/w]mb are better.
> Tyler, Honnappa, Ruifeng, Konstantin, what do you think?
>
Yes, extra notes sounds like a reasonable thing to me.
