> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Tuesday, June 13, 2023 9:39 AM > To: Arnaud Fiorini <[email protected]>; Van Haaren, Harry > <[email protected]> > Cc: Thomas Monjalon <[email protected]>; Jerin Jacob > <[email protected]>; Sunil Kumar Kori <[email protected]>; [email protected] > Subject: Re: [PATCH v3] eal: add tracepoints to track lcores and services > > Hello,
Hi David, > On Fri, May 12, 2023 at 4:30 PM Arnaud Fiorini > <[email protected]> wrote: > > > > The tracepoints added are used to track lcore role and status, > > as well as service mapping and service runstates. These > > tracepoints are then used in analyses in Trace Compass. > > > > Signed-off-by: Arnaud Fiorini <[email protected]> > > Harry, the majority of trace points added by this patch are in the service > code. > Could you review please? Performance wise, this patch is the same as V1 comments, no concerns here just noting that enabling tracing impacts perf. http://patches.dpdk.org/project/dpdk/patch/[email protected]/#159839 Docs look good, thanks for adding the --trace= example, it will help users in future! Acked-by: Harry van Haaren <[email protected]>
