Hi Stephen, > -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Monday, May 15, 2023 11:53 PM > To: Li, Miao <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Xia, Chenbo > <[email protected]>; Cao, Yahui <[email protected]>; Burakov, Anatoly > <[email protected]> > Subject: Re: [PATCH v1 4/4] bus/pci: add VFIO sparse mmap support > > On Mon, 15 May 2023 06:47:00 +0000 > Miao Li <[email protected]> wrote: > > > + map_addr = pci_map_resource(addr, vfio_dev_fd, > > + bar->offset + sparse->offset, > > sparse->size, > > + RTE_MAP_FORCE_ADDRESS); > > + if (map_addr == NULL) { > > + munmap(bar_addr, bar->size); > > + RTE_LOG(ERR, EAL, "Failed to map pci > BAR%d\n", > > + bar_index); > > If mmap() fails then printing errno would help diagnose why.
Thanks for your review! It seems errno will be printed in function pci_map_resource() when mmap() fails. So I guess we don't need it here? Thanks, Chenbo
