On Tue, Apr 4, 2023 at 3:01 PM Ferruh Yigit <[email protected]> wrote: > > On 4/4/2023 1:36 PM, David Marchand wrote: > > Kernel checkpatch.pl is confused about RTE_BUILD_BUG_ON() and warns as if > > our code was calling the kernel macro BUG_ON(). > > > > This does not make sense in the DPDK userspace code and the Linux kernel > > module hosted in our repository (kernel/linux/kni) won't make it upstream. > > > > Disable this warning. > > > > Signed-off-by: David Marchand <[email protected]> > > Sounds reasonable, > Acked-by: Ferruh Yigit <[email protected]> > > > Is there any occurrence in the public CI, as reference?
I caught it when preparing submission of: https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/ dpdk.org checkpath did not catch it, so it is probably lagging a bit. For reference, in my environment, this looks like: ### [PATCH] malloc: rework heap destroy WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #23: FILE: lib/eal/common/malloc_heap.c:1389: + RTE_BUILD_BUG_ON(offsetof(struct malloc_heap, lock) != 0); total: 0 errors, 1 warnings, 23 lines checked 0/1 valid patch -- David Marchand
