On 2/8/23 03:00, Hernan Vargas wrote:
Fix potential issue of dereferencing a pointer before null check.
Remove null check for value that could never be null.

Coverity issue: 381646, 381631
Fixes: 989dec301a9 ("baseband/acc100: add ring companion address")
Cc: [email protected]

Signed-off-by: Hernan Vargas <[email protected]>
---
  drivers/baseband/acc/rte_acc100_pmd.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/baseband/acc/rte_acc100_pmd.c 
b/drivers/baseband/acc/rte_acc100_pmd.c
index 36f6fec5ad..baab459436 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data 
*q_data,
        int ret, cbm;
        struct rte_bbdev_enc_op *op;
- if (q == NULL)
-               return 0;
  #ifdef RTE_LIBRTE_BBDEV_DEBUG
        if (unlikely(ops == 0))
                return 0;

Reviewed-by: Maxime Coquelin <[email protected]>

Thanks,
Maxime

Reply via email to