> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Tuesday, February 7, 2023 6:46 PM > To: [email protected] > Cc: [email protected]; [email protected]; Xia, Chenbo > <[email protected]>; Hu, Jiayu <[email protected]>; Wang, YuanX > <[email protected]>; Ding, Xuan <[email protected]>; > [email protected] > Subject: [PATCH v6 9/9] vhost: enable lock check > > Now that all locks in this library are annotated, we can enable the > check. > > Signed-off-by: David Marchand <[email protected]> > Acked-by: Morten Brørup <[email protected]> > Reviewed-by: Maxime Coquelin <[email protected]> > --- > lib/vhost/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build > index bc7272053b..197a51d936 100644 > --- a/lib/vhost/meson.build > +++ b/lib/vhost/meson.build > @@ -17,6 +17,8 @@ elif (toolchain == 'icc' and > cc.version().version_compare('>=16.0.0')) > endif > dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', > cc.has_header('linux/userfaultfd.h')) > cflags += '-fno-strict-aliasing' > + > +annotate_locks = true > sources = files( > 'fd_man.c', > 'iotlb.c', > -- > 2.39.1
Reviewed-by: Chenbo Xia <[email protected]> After going through the whole series, I agree it does need much effort to add all these annotations.. But I also believe it will bring more benefits :) Thanks for the work, David!
