David Marchand, Feb 06, 2023 at 09:48:
> +struct rte_lcore_usage { > + /** The total amount of time since application start, in TSC cycles. */ > + uint64_t total_cycles;This code comment needs some clarification. What is this "total amount of time"? "application start" is ambiguous. EAL lcore threads are not created/started by the application itself, so the application has no idea of the time the lcore/threads were created. I would describe as: /** The total amount of time that the application has been running on this lcore, in TSC cycles. */ Is it acceptable to you?
Yes, this leaves less room for interpretation.
> + /** The amount of busy time since application start, in TSC cycles. */ > + uint64_t busy_cycles; And here: /** The amount of time the application was busy, handling some workload on this lcore, in TSC cycles. */
This is in line with the total. Looks good to me. I will address that and your other comments for v9.
