> -----Original Message-----
> From: Yang, Qiming <[email protected]>
> Sent: Thursday, February 2, 2023 2:10 PM
> To: Deng, KaiwenX <[email protected]>; [email protected]
> Cc: [email protected]; Zhou, YidingX <[email protected]>; Wu,
> Wenjun1 <[email protected]>; Zhao1, Wei <[email protected]>;
> Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>;
> Dai, Wei <[email protected]>
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Hi, Kaiwen
>
> The code looks good to me.
> Can you ask someone to test this behavior and add a tested-by?
>
> Qiming
>
Hi,Qiming
Peng Yuan just added tested-by.
Kaiwen
> > -----Original Message-----
> > From: Deng, KaiwenX <[email protected]>
> > Sent: Saturday, January 28, 2023 3:15 PM
> > To: [email protected]
> > Cc: [email protected]; Zhou, YidingX <[email protected]>; Deng,
> > KaiwenX <[email protected]>; Yang, Qiming
> > <[email protected]>; Wu, Wenjun1 <[email protected]>;
> Zhao1,
> > Wei <[email protected]>; Xing, Beilei <[email protected]>; Lu,
> > Wenzhuo <[email protected]>; Dai, Wei <[email protected]>
> > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> >
> > Add IPv6 addr mask and L4 mask support for rte_flow APIs.
> >
> > IPv6 flow rules do not take effect in ixgbe when set
> > IPv6 addr mask and L4 mask to default value as 0xFF.
> >
> > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
> >
> > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > Cc: [email protected]
> >
> > Signed-off-by: Kaiwen Deng <[email protected]>
> > ---
> > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> > rte_eth_dev *dev,
> > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> > rule->mask.vlan_tci_mask = 0;
> > rule->mask.flex_bytes_mask = 0;
> > + rule->mask.dst_port_mask = 0;
> > + rule->mask.src_port_mask = 0;
> > + rule->mask.src_ipv6_mask = 0;
> > + rule->mask.dst_ipv6_mask = 0;
> >
> > /**
> > * The first not void item should be
> > --
> > 2.34.1
