> -----Original Message----- > From: Morten Brørup <[email protected]> > Sent: Monday, January 30, 2023 1:45 PM > To: Sunil Kumar Kori <[email protected]>; Ankur Dwivedi > <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Igor Russkikh <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; Jerin Jacob Kollanukkaran > <[email protected]>; Maciej Czekaj [C] <[email protected]>; Shijith > Thotton <[email protected]>; Srisivasubramanian Srinivasan > <[email protected]>; Harman Kalra <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Nithin Kumar Dabilpuram > <[email protected]>; Kiran Kumar Kokkilagadda > <[email protected]>; Satha Koteswara Rao Kottidi > <[email protected]>; Liron Himi <[email protected]>; > [email protected]; Radha Chintakuntla <[email protected]>; > Veerasenareddy Burru <[email protected]>; Sathesh B Edara > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Rasesh Mody > <[email protected]>; Shahed Shaikh <[email protected]>; Devendra > Singh Rawat <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Ankur Dwivedi > <[email protected]> > Subject: [EXT] RE: [PATCH v7 1/6] eal: trace: add trace point emit for blob > > External Email > > ---------------------------------------------------------------------- > > From: Sunil Kumar Kori [mailto:[email protected]] > > Sent: Monday, 30 January 2023 08.31 > > > > > From: Ankur Dwivedi <[email protected]> > > > Sent: Monday, January 23, 2023 2:32 PM > > > > > [...] > > > > +RTE_TRACE_POINT( > > > + rte_eal_trace_generic_blob, > > > + RTE_TRACE_POINT_ARGS(void *in, uint8_t len), > > > + rte_trace_point_emit_blob(in, len); > > > +) > > > + > > > > As per documentation rte_eal_trace_generic_blob() will emit 64 bytes > > only i.e. input array cannot be other than uint8_t. > > So will it not be better to make it more readable like > > RTE_TRACE_POINT_ARGS(uint8_t *in, uint8_t len) instead of using void > > *in. > > No. Using uint8_t* would cause type conversion problems. The advantage of > using void* is that it is has no type - which is exactly the purpose of a BLOB > (which is short for Binary Large OBject). We want to be able to pass a pointer > to e.g. a structure. Using void* makes that directly available. > > I didn't notice before, but the const qualifier is missing. It should be: > > RTE_TRACE_POINT_ARGS(const void *in, uint8_t len), >
Makes sense. Ack. > > > > Rest is fine. Already acked above. > > > > > #define RTE_EAL_TRACE_GENERIC_FUNC > > > rte_eal_trace_generic_func(__func__) > > > > > > /* Interrupt */ > > > > [snipped] > > > > > 2.25.1 > >
