Hi Ferruh, My comments are inline.
>-----Original Message----- >From: Ferruh Yigit <[email protected]> >Sent: Thursday, January 12, 2023 10:33 PM >To: Ankur Dwivedi <[email protected]>; [email protected] >Cc: [email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; Igor Russkikh ><[email protected]>; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected]; Jerin Jacob >Kollanukkaran <[email protected]>; Maciej Czekaj [C] ><[email protected]>; Shijith Thotton <[email protected]>; >Srisivasubramanian Srinivasan <[email protected]>; Harman Kalra ><[email protected]>; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; Nithin Kumar Dabilpuram <[email protected]>; >Kiran Kumar Kokkilagadda <[email protected]>; Sunil Kumar Kori ><[email protected]>; Satha Koteswara Rao Kottidi ><[email protected]>; Liron Himi <[email protected]>; >[email protected]; Radha Chintakuntla <[email protected]>; >Veerasenareddy Burru <[email protected]>; Sathesh B Edara ><[email protected]>; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; Rasesh Mody ><[email protected]>; Shahed Shaikh <[email protected]>; Devendra >Singh Rawat <[email protected]>; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; [email protected]; >[email protected] >Subject: [EXT] Re: [PATCH v5 0/6] add trace points in ethdev library > >External Email > >---------------------------------------------------------------------- >On 1/12/2023 11:21 AM, Ankur Dwivedi wrote: >> This series adds trace points for functions in the ethdev library. >> The trace points are added in ethdev, flow, mtr and tm files. >> >> v5: >> - The rte_trace_point_emit_char_array function is renamed to >> rte_trace_point_emit_blob. With this function an array of >> any length upto 65535 bytes can be captured. >> For example, the following is the ctf metadata created to display >> a mac addr array in rte_eth_trace_macaddr_get(): >> struct { >> ... >> uint16_t len; >> uint8_t mac_addr_addr_bytes[len]; >> }; >> - Added additional test cases for rte_eal_trace_generic_blob >> test case. >> - Capturing of return value of a function is added to tracepoint >> for flow, mtr and tm patches. >> - In ehdev patch (1/6), removed extra line. Also added rx_pkts and >> tx_pkts pointer in trace point. >> >> v4: >> - Adds tracepoint function to emit char array. Also adds the >> test case. >> - Resolved review comments on "ethdev: add trace point" patch. >> This patch is divided into 2 patches to minimize per patch >> size. >> - From the earlier version (v3), few tracepoints in ethdev, >> flow, mtr, tm are made as fast path tracepoints. For the >> tracepoint which i was unsure, i have made it as fastpath. >> All the fast path tracepoints can be found in >> rte_ethdev_trace_fp.h and rte_ethdev_trace_fp_burst.h. >> All the slow path tracepoints can be found in rte_ethdev_trace.h. >> - Capturing of return value is added to tracepoint in ethdev. >> For flow, mtr and tm these changes are still yet to bde done. >> Will do it in the next versions. >> - Moved the trace functions from INTERNAL to EXPERIMENTAL in >> version.map. >> >> v3: >> - Moved the trace functions from EXPERIMENTAL to INTERNAL in >> version.map. >> - Moved trace functions call to the end, in ethdev and flow trace. >> - Added code to print the input value of features in >> rte_eth_trace_rx_metadata_negotiate(). >> - Added code to capture return value in flow trace. >> >> Ankur Dwivedi (6): >> eal: trace: add trace point emit for blob >> ethdev: add trace points for ethdev >> ethdev: add trace points for remaining functions >> ethdev: add trace points for flow >> ethdev: add trace points for mtr >> ethdev: add trace points for tm > >Hi Ankur, > >Build seems failing with set, can you please check: >https://urldefense.proofpoint.com/v2/url?u=https- >3A__mails.dpdk.org_archives_test-2Dreport_2023- >2DJanuary_339696.html&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=ILjiNF3 >GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=FhQtWKgLxBWQ7rF_fkPm7V >K5-efg3NcVDA6cTbGsoNZmX7WvvZKas2o4xnsIxj5D&s=HDHVPZX4YsLz- >DsRwK3mRisxOk9U8FK7fStn7gCgsXk&e= > >I can reproduce build failures via 32bit and debugoptimized builds. Sure, I will check.
