10/11/2022 10:27, Juraj Linkeš:
> From: Thomas Monjalon <[email protected]>
> > usage() {
> > - echo "Run formatting and linting programs for DTS. Usage:"
> > -
> > + echo 'Usage: $(basename $0) [options] [directory]'
>
> Double quotes here, otherwise $0 won't be expanded.
I wonder how I tested it :)
> > +directory=${1:-$(dirname $0)/../dts}
> > +cd $directory || exit 1
>
> I'd like to include the information of where we're doing the fomatting in the
> console output, e.g.:
> echo "Formatting in $(pwd):"
>
> We're silently chaning the directory, so this would be useful when running
> with no argument and the script doesn't change anything - as a confirmation
> that it ran over the files we wanted to.
Good comment, I'll improve in v2.
> Other than that,
> Reviewed-by: Juraj Linkeš <[email protected]>
> Tested-by: Juraj Linkeš <[email protected]>
No it does not work, so you should not add your Tested-by.
And in general, Reviewed-by is enough.
And really, give your reviewed-by only when it's perfect :)
