Hi lihuisong, This means that queue offloads need to update by recalling dev_configure and setup target queues. Can you tell me, where is the limitation?
Thanks, Mingjin > -----Original Message----- > From: lihuisong (C) <[email protected]> > Sent: 2022年10月26日 17:53 > To: Ye, MingjinX <[email protected]>; [email protected] > Cc: [email protected]; Zhou, YidingX <[email protected]>; Singh, Aman > Deep <[email protected]>; Zhang, Yuying > <[email protected]> > Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq > > > 在 2022/10/27 1:10, Mingjin Ye 写道: > > After setting vlan offload in testpmd, the result is not updated to > > rxq. Therefore, the queue needs to be reconfigured after executing the > > "vlan offload" related commands. > > > > Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support") > > Cc: [email protected] > > > > Signed-off-by: Mingjin Ye <[email protected]> > > --- > > app/test-pmd/cmdline.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 17be2de402..ce125f549f 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -4133,6 +4133,7 @@ cmd_vlan_offload_parsed(void *parsed_result, > > else > > vlan_extend_set(port_id, on); > > > > + cmd_reconfig_device_queue(port_id, 1, 1); > This means that queue offloads need to upadte by re-calling dev_configure > and setup all queues, right? > If it is, this adds a usage limitation. > > return; > > } > >
