> -----Original Message-----
> From: Richardson, Bruce <[email protected]>
> Sent: Tuesday 25 October 2022 11:39
> To: David Marchand <[email protected]>
> Cc: Mattias Rönnblom <[email protected]>; [email protected]; Morten
> Brørup <[email protected]>; Power, Ciara
> <[email protected]>
> Subject: Re: [PATCH v3 1/4] telemetry: support boolean type
>
> On Tue, Oct 25, 2022 at 11:43:27AM +0200, David Marchand wrote:
> > On Tue, Oct 25, 2022 at 11:34 AM Mattias Rönnblom
> <[email protected]> wrote:
> > >
> > > On 2022-10-25 11:00, David Marchand wrote:
> > > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and
> dicts.
> > > >
> > > > Signed-off-by: David Marchand <[email protected]>
> > > > Acked-by: Morten Brørup <[email protected]>
> > > > Acked-by: Bruce Richardson <[email protected]>
> > > > Acked-by: Ciara Power <[email protected]>
> > > > ---
> > > > Changes since v1:
> > > > - fixed doxygen description,
<snip>
> > I'll let the telemetry maintainers decide on the fate of those patches.
> > Thanks.
> >
> Well, given the lateness in the release process, if it's a choice between
> getting the patches in as-is, vs not getting them in at all, I think having
> them
> in 22.11 is the better choice. While there is cleanup that can be done, I
> don't
> see this patch as making the overall code any worse.
>
> My 2c.
>
> /Bruce
Agreed, it's a good addition to the library, +1 to having it in 22.11
Thanks,
Ciara