> -----Original Message-----
> From: Andrew Rybchenko <[email protected]>
> Sent: Tuesday, October 25, 2022 4:57 PM
> To: Guo, Junfeng <[email protected]>; Zhang, Qi Z
> <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei
> <[email protected]>
> Cc: [email protected]; Li, Xiaoyun <[email protected]>; Wang, Xiao W
> <[email protected]>
> Subject: Re: [PATCH v11 02/18] net/idpf: add support for device initialization
>
> On 10/24/22 16:12, Junfeng Guo wrote:
> > Support device init and add the following dev ops:
> > - dev_configure
> > - dev_close
> > - dev_infos_get
> >
> > Signed-off-by: Beilei Xing <[email protected]>
> > Signed-off-by: Xiaoyun Li <[email protected]>
> > Signed-off-by: Xiao Wang <[email protected]>
> > Signed-off-by: Junfeng Guo <[email protected]>
>
> [snip]
>
> > diff --git a/doc/guides/nics/features/idpf.ini
> > b/doc/guides/nics/features/idpf.ini
> > new file mode 100644
> > index 0000000000..7a44b8b5e4
> > --- /dev/null
> > +++ b/doc/guides/nics/features/idpf.ini
> > @@ -0,0 +1,10 @@
> > +;
> > +; Supported features of the 'idpf' network poll mode driver.
> > +;
> > +; Refer to default.ini for the full list of available PMD features.
> > +;
> > +; A feature with "P" indicates only be supported when non-vector path
> > +; is selected.
>
> The statement should be added when the first P appears.
Thanks for the comments, all the comments are addressed in next version except
the below one.
[snip]
> > +};
> > +
> > +struct idpf_vport {
> > + struct idpf_adapter *adapter; /* Backreference to associated adapter
> */
> > + uint16_t vport_id;
> > + uint32_t txq_model;
> > + uint32_t rxq_model;
> > + uint16_t num_tx_q;
>
> Shouldn't it be set as the result of configure?
> data->nb_tx_queues which is the result of the configure is not
> used in the patch?
The num_tx_q here is different from data->nb_tx_queues.
The idpf PMD requires fixed txqs and rxqs when the idpf PMD requires creating a
vport.
The num_tx_q and the num_rxq_q are the values returned by backend.
But there'll be only data->nb_tx_queues txqs configured during dev_start.
