Hi Hernan, On 10/12/22 04:53, Hernan Vargas wrote:
Refactor of the queue availability computation to prevent the application to dequeue more than what may have been enqueued.Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: [email protected] Signed-off-by: Hernan Vargas <[email protected]> --- drivers/baseband/acc/rte_acc100_pmd.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index e84d9f2511..733766ad3e 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -2876,7 +2876,7 @@ acc100_enqueue_enc_cb(struct rte_bbdev_queue_data *q_data, struct rte_bbdev_enc_op **ops, uint16_t num) { struct acc_queue *q = q_data->queue_private; - int32_t avail = q->sw_ring_depth + q->sw_ring_tail - q->sw_ring_head; + int32_t avail = acc_ring_avail_enq(q);
That's problematic because the patch introducing acc_ring_avail_enq() is a feature patch for v22.11 and not a fix. You'll have to help the LTS maintainers to backport it. Other than that: Reviewed-by: Maxime Coquelin <[email protected]> Thanks, Maxime
