On 2/15/2022 7:04 AM, Haiyue Wang wrote:
Align to Tx desc number check indent, which may help to understand Rx descriptor limits member in the alignment comparison view. And remove the extra empty line.Signed-off-by: Haiyue Wang <haiyue.w...@intel.com> --- lib/ethdev/rte_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 70c850a2f1..54f1e14c6b 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1799,9 +1799,8 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, }if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||- nb_rx_desc < dev_info.rx_desc_lim.nb_min || - nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { - + nb_rx_desc < dev_info.rx_desc_lim.nb_min || + nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) { RTE_ETHDEV_LOG(ERR, "Invalid value for nb_rx_desc(=%hu), should be: <= %hu, >= %hu, and a product of %hu\n", nb_rx_desc, dev_info.rx_desc_lim.nb_max,
Hi Haiyue, Initial code matches to DPDK coding convention, updated code doesn't: https://doc.dpdk.org/guides/contributing/coding_style.html And I don't think syntax only updates are good idea, it corrupts the git history with minimal gain, instead better to fix them while doing a functional changes in those lines.
