On 03/12/2021 07:54, [email protected] wrote:
From: Christian Ehrhardt <[email protected]>
It was important in the past to select anything with "fix" in the
headline, but recently more often created false positives and work
to sort tihngs out than identifying many helpful patches.
The community and processes aroudn DPDK matured enough that developers
(rightfully) expect to rely on "Fixes:" and "stable@" marking for
backprots.
nit: several typos here and i think it should say "or" stable@
Therefore do no more include patches that just include the word fix
in the backport candidate list.
Signed-off-by: Christian Ehrhardt <[email protected]>
---
devtools/git-log-fixes.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index 210c8dcf25..27ec9088d4 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -13,7 +13,7 @@ print_help ()
cat <<- END_OF_HELP
Find fixes to backport on previous versions.
- It looks for the word "fix" in the headline or a tag "Fixes" or
"Reverts".
+ It looks for a tag "Fixes" or "Reverts" and for recipient
[email protected].
"..or for recipient [email protected]."
Good idea, thanks. With minor fixes,
Acked-by: Kevin Traynor <[email protected]>
The oldest bug origin is printed as well as partially fixed versions.
END_OF_HELP
}
@@ -109,8 +109,7 @@ while read id headline ; do
origins=$(origin_filter $id)
stable=$(stable_tag $id)
fixes=$(fixes_tag $id)
- [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \
- echo "$headline" | grep -q fix || continue
+ [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] ||
continue
version=$(commit_version $id)
if [ -n "$origins" ] ; then
origver="$(origin_version $origins)"
