Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

[Dariusz Sosnowski]

Hi,

On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote:
> > Substituting options with NOOP might cause rte_ipv4_fragment_packet to 
> > produce more fragments than necessary, since options with copied flag unset 
> > will still occupy space in IPv4 header.
> --The "ip_options_fragment" just make a replacement and doesn't change the 
> length of the IPv4 header.So I don't quite understand why it leads to produce 
> more fragments.
If options with copied flag unset are not copied, then IPv4 headers in the 
fragments (despite 1st fragment) will be shorter. This leaves more byte space 
for the payload and in effect fragmentation might produce less fragments.

Best regards,
Dariusz Sosnowski