> -----Original Message-----
> From: Peng, ZhihongX <[email protected]>
> Sent: Tuesday, October 19, 2021 2:59 PM
> To: [email protected]; Burakov, Anatoly
> <[email protected]>; Ananyev, Konstantin
> <[email protected]>; [email protected];
> Dumitrescu, Cristian <[email protected]>; Mcnamara, John
> <[email protected]>; Richardson, Bruce
> <[email protected]>
> Cc: [email protected]; Lin, Xueqin <[email protected]>; Peng, ZhihongX
> <[email protected]>
> Subject: [PATCH v12 3/4] Code changes to avoid the ASan error
>
> From: Zhihong Peng <[email protected]>
>
> Code changes to avoid the following ASan error:
> "Control reaches end of non-void function".
>
> Cc: [email protected]
>
> Signed-off-by: Xueqin Lin <[email protected]>
> Signed-off-by: Zhihong Peng <[email protected]>
> ---
> v7: no change.
> v8: no change.
> v9: Modify the submit log.
> v10:no change.
> v11:no change.
> v12:Modify the commit log.
> ---
> lib/pipeline/rte_swx_pipeline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c
> index 1cd09a4b44..0acd6c6752 100644
> --- a/lib/pipeline/rte_swx_pipeline.c
> +++ b/lib/pipeline/rte_swx_pipeline.c
> @@ -4642,7 +4642,7 @@ instr_meter_translate(struct rte_swx_pipeline *p,
> return 0;
> }
>
> - CHECK(0, EINVAL);
> + return -EINVAL;
> }
>
> static inline void
> @@ -5937,7 +5937,7 @@ instr_translate(struct rte_swx_pipeline *p,
> instr,
> data);
>
> - CHECK(0, EINVAL);
> + return -EINVAL;
> }
>
> static struct instruction_data *
> --
> 2.25.1
This patch changes code working correctly just to please the tool. We should
look at ways to fix the tooll, as this is likely going to be a recurring issue.
Hopefully this tool is to provide value to DPDK users.
Reluctantly,
Acked-by: Cristian Dumitrescu <[email protected]>
