Hi, Maxime Very nice catch, thank you for the patch. Minor typo in the commit message "ithat" -> "that". Besides this:
Acked-by: Viacheslav Ovsiienko <[email protected]> > -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Friday, September 10, 2021 12:18 > To: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; Michael Baum <[email protected]>; Slava > Ovsiienko <[email protected]> > Cc: [email protected]; NBU-Contact-N?lio Laranjeiro > <[email protected]>; Maxime Coquelin > <[email protected]> > Subject: [PATCH 3/3] net/mlx5: Fix RSS RETA update > > This patch fixes RETA updating for entries above 64. > Without ithat, these entries are never updated as calculated mask value will > always be 0. > > Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Maxime Coquelin <[email protected]> > --- > drivers/net/mlx5/mlx5_rss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index > c32129cdc2..6dc52acee0 100644 > --- a/drivers/net/mlx5/mlx5_rss.c > +++ b/drivers/net/mlx5/mlx5_rss.c > @@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, > for (idx = 0, i = 0; (i != reta_size); ++i) { > idx = i / RTE_RETA_GROUP_SIZE; > pos = i % RTE_RETA_GROUP_SIZE; > - if (((reta_conf[idx].mask >> i) & 0x1) == 0) > + if (((reta_conf[idx].mask >> pos) & 0x1) == 0) > continue; > MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); > (*priv->reta_idx)[i] = reta_conf[idx].reta[pos]; > -- > 2.31.1
