Default RSS for outer src/dst IP address field in iavf is not supported before, so it does not cause any error. However, if it can be dropped, I suggest to do so. It seems to be safer to add IPID field here.
> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Tuesday, September 7, 2021 3:10 PM > To: Wu, Wenjun1 <[email protected]>; Yigit, Ferruh > <[email protected]> > Cc: dev <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi > Z <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from > default hash field > > On Tue, Sep 7, 2021 at 9:05 AM Wenjun Wu <[email protected]> wrote: > > > > We try to refine default RSS for IP fragment packets. However, the > > change will lead to more serious errors. The scenario that there is > > overlap/conflict between the new characteristics and the existing ones > > has not been supported, so non-fragment packets and fragment packets > > cannot share the same hash fields, or all related profiles will be > > removed. > > > > Therefore, IPID field is necessary for fragment packets. > > > > Fixes: cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment > > packets") > > > > Signed-off-by: Wenjun Wu <[email protected]> > > - If this is a revert of cf37e1e5e9d2, maybe it is simpler to drop the > original > change in next-net before it gets pulled in the main repo. > - A similar change has been applied to net/iavf? Is it still relevant? > > > -- > David Marchand
